Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt at fix for flaky Cases FTR tests #156248

Merged
merged 2 commits into from
May 1, 2023
Merged

Attempt at fix for flaky Cases FTR tests #156248

merged 2 commits into from
May 1, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented May 1, 2023 •
edited
Loading

Resolves #154727
Resolves #154726
Resolves #155659
Resolves #155658

Summary

Attempts to fix Cases FTR tests by retrying / awaiting more.

Ran Flaky Test Runner on this PR set to 50 iterations and it passes: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2198#0187d699-3909-4a72-9289-09f775f59139

@CoenWarmer CoenWarmer requested a review from a team as a code owner May 1, 2023 09:14
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added release_note:skip Skip the PR/issue when compiling release notes backport labels May 1, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 479 482 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer enabled auto-merge (squash) May 1, 2023 10:07
@maryam-saeidi
Copy link
Member

What does the backport label do? Do we need to backport functional test fixes?

@CoenWarmer
Copy link
Contributor Author

What does the backport label do? Do we need to backport functional test fixes?

@maryam-saeidi I'd like to include the fix for this in 8.8.0. If we don't includebackport, this fix will be included in the next release, be it minor or major.

@maryam-saeidi
Copy link
Member

maryam-saeidi commented May 1, 2023 •
edited
Loading

@maryam-saeidi I'd like to include the fix for this in 8.8.0. If we don't includebackport, this fix will be included in the next release, be it minor or major.

So backport includes the changes in the previous minor? My question was the other way around about which previous version backport targets. (We also have the label backport:prev-minor specifically to target previous minor)

@CoenWarmer
Copy link
Contributor Author

CoenWarmer commented May 1, 2023 •
edited
Loading

@maryam-saeidi I'd like to include the fix for this in 8.8.0. If we don't includebackport, this fix will be included in the next release, be it minor or major.

So backport includes the changes in the previous minor? My question was the other way around about which previous version backport targets.

We are already past the 8.8.0 release cut off (being feature freeze). Anything that gets merged into main now will be be included into the next release after 8.8.0, be that minor or major. So In order to get a PR into the release that will come out on May 16th (8.8.0), we need to backport that PR.

maryam-saeidi
maryam-saeidi approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@CoenWarmer CoenWarmer merged commit e6366c0 into elastic:main May 1, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 1, 2023
@CoenWarmer CoenWarmer added v8.8.0 and removed backport:skip This commit does not require backporting labels May 1, 2023
@CoenWarmer
Copy link
Contributor Author

@maryam-saeidi I'd like to include the fix for this in 8.8.0. If we don't includebackport, this fix will be included in the next release, be it minor or major.

So backport includes the changes in the previous minor? My question was the other way around about which previous version backport targets.

We are already past the 8.8.0 release cut off (being feature freeze). Anything that gets merged into main now will be be included into the next release after 8.8.0, be that minor or major. So In order to get a PR into the release that will come out on May 16th (8.8.0), we need to backport that PR.

@maryam-saeidi According to @sphilipse the backport label does not actually do anything anymore. The version label triggers the backport, not backport or backport-prev-minor. I've pinged Kibana Ops to see if it is possible to remove these labels if they actually don't anything to prevent confusion.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 20, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 156248 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 156248 locally

@sphilipse sphilipse removed backport backport missing Added to PRs automatically when the are determined to be missing a backport. v8.8.0 labels Jan 24, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 25, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 156248 locally

@sphilipse sphilipse removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.9.0 labels Jan 26, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 29, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 156248 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 156248 locally

@sphilipse sphilipse added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/cases/case_details·ts - ObservabilityApp Observability cases Case detail rule link "after all" hook for "should link to observability rule pages in case details" Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/cases/case_details·ts - ObservabilityApp Observability cases Case detail rule link "before all" hook for "should link to observability rule pages in case details" Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/alerts/add_to_case·ts - ObservabilityApp Observability alerts / Add to case > When user has all priviledges for cases opens a flyout when Add to new case is clicked Failing test: Chrome X-Pack Observability UI Functional Tests.x-pack/test/observability_functional/apps/observability/pages/alerts/add_to_case·ts - ObservabilityApp Observability alerts / Add to case > When user has all priviledges for cases renders case options in the overflow menu
6 participants
@CoenWarmer @apmmachine @kibana-ci @maryam-saeidi @kibanamachine @sphilipse